On 28 Sep 2006 11:21:55 +0200 Andrew Victor <[email protected]> wrote: > hi Haavard, > > > at91_register_uart_fns has no users as far as I can see. Let's get > > rid of it. > > No. It is being used. > > This interface is used to register board-specific functions that can > be use to control the serial port modem-control lines. > > For example, the AT91RM9200 only provides the full modem-control > signals on USART1. If you need the modem-control signals for any of > the other ports you need to drive some of the GPIO pins manually. So > you need this hook back into your board-specific file to do that. Ok, I sort of suspected that. But I can't see any users in the kernel tree, so perhaps we should leave the name of the function alone too? (i.e. just drop the patch) Haavard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 8/8] atmel_serial: Kill at91_register_uart_fns
- From: Andrew Victor <[email protected]>
- Re: [PATCH 8/8] atmel_serial: Kill at91_register_uart_fns
- References:
- [PATCH 0/8] Rename at91_serial driver as atmel_serial
- From: Haavard Skinnemoen <[email protected]>
- [PATCH 1/8] at91_serial -> atmel_serial: at91rm9200_usart.h
- From: Haavard Skinnemoen <[email protected]>
- [PATCH 2/8] at91_serial -> atmel_serial: at91_serial.c
- From: Haavard Skinnemoen <[email protected]>
- [PATCH 3/8] at91_serial -> atmel_serial: Kconfig symbols
- From: Haavard Skinnemoen <[email protected]>
- [PATCH 4/8] at91_serial -> atmel_serial: Platform device name
- From: Haavard Skinnemoen <[email protected]>
- [PATCH 5/8] at91_serial -> atmel_serial: Public definitions
- From: Haavard Skinnemoen <[email protected]>
- [PATCH 6/8] at91_serial -> atmel_serial: Internal names
- From: Haavard Skinnemoen <[email protected]>
- [PATCH 7/8] serial: Rename PORT_AT91 -> PORT_ATMEL
- From: Haavard Skinnemoen <[email protected]>
- [PATCH 8/8] atmel_serial: Kill at91_register_uart_fns
- From: Haavard Skinnemoen <[email protected]>
- Re: [PATCH 8/8] atmel_serial: Kill at91_register_uart_fns
- From: Andrew Victor <[email protected]>
- [PATCH 0/8] Rename at91_serial driver as atmel_serial
- Prev by Date: Re: [PATCH] x86[-64] PCI domain support
- Next by Date: Re: 2.6.18-git7 freezes solid on boot
- Previous by thread: Re: [PATCH 8/8] atmel_serial: Kill at91_register_uart_fns
- Next by thread: Re: [PATCH 8/8] atmel_serial: Kill at91_register_uart_fns
- Index(es):
 |