On 28 Sep 2006 10:34:49 +0200
Andrew Victor <[email protected]> wrote:
> hi Haavard,
>
> > Rename the following Kconfig symbols:
> > * CONFIG_SERIAL_AT91 -> CONFIG_SERIAL_ATMEL
> > * CONFIG_SERIAL_AT91_CONSOLE -> CONFIG_SERIAL_ATMEL_CONSOLE
> > * CONFIG_SERIAL_AT91_TTYAT -> CONFIG_SERIAL_ATMEL_TTYAT
>
>
> > -config SERIAL_AT91
> > - bool "AT91RM9200 / AT91SAM9261 serial port support"
> > +config SERIAL_ATMEL
> > + bool "AT91 / AT32 on-chip serial port support"
> > depends on ARM && (ARCH_AT91RM9200 || ARCH_AT91SAM9261)
> > select SERIAL_CORE
> > help
> > This enables the driver for the on-chip UARTs of the
> > Atmel AT91RM9200 and AT91SAM926 processor.
>
> Shouldn't this dependency be:
> depends on (ARM && ARCH_AT91) || AVR32
>
> (The "ARCH_AT91RM9200 || ARCH_AT91SAM9261" can be replaced with
> ARCH_AT91 since the driver should usable on the RM9200, SAM9261 and
> SAM9260)
Oh, I didn't know that symbol existed. I just looked at the serial
Kconfig, not arch/arm/Kconfig. You're right of course.
> The help text should probably also be updated for these 3 options so
> that it mentions the AVR32.
Right. Probably shouldn't have changed the prompt -- I have a different
patch that actually adds AVR32 support (I don't want to do that before
it actually compiles on AVR32, in case some crazy person comes along
and tries out allyesconfig ;)
Is it OK if I keep the patch as it is and change the dependency and
help text in a later patch?
Haavard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
