Re: [PATCH] fix idiocy in asd_init_lseq_mdp()

--- Douglas Gilbert <[email protected]> wrote:
> Al Viro wrote:
> > To whoever had written that code:
> > 
> > a) priority of >> is higher than that of &
> > b) priority of typecast is higher than that of any binary operator
> > c) learn the fscking C
[...]
> BTW Luben was pointing out that the call you patched
> and the following call can be combined into a less
> trouble prone asd_write_reg_dword() call.

More than that -- I looked at the history of that
file/line and the code as I had written it _never_ had
that broken cast and shift mess.

"Someone" changed that after I submitted the code to lkml/lsml.

    Luben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix idiocy in asd_init_lseq_mdp()
    • From: Al Viro <[email protected]>

• References:
  • Re: [PATCH] fix idiocy in asd_init_lseq_mdp()
    • From: Douglas Gilbert <[email protected]>

• Prev by Date: Re: NV SATA breakage: jgarzik/libata-dev#upstream etc
• Next by Date: Re: [patch] remove MNT_NOEXEC check for PROT_EXEC mmaps
• Previous by thread: Re: [PATCH] fix idiocy in asd_init_lseq_mdp()
• Next by thread: Re: [PATCH] fix idiocy in asd_init_lseq_mdp()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]