Al Viro wrote:
> To whoever had written that code:
>
> a) priority of >> is higher than that of &
> b) priority of typecast is higher than that of any binary operator
> c) learn the fscking C
Al,
On the assumption that you have hardware that uses this
driver, did you notice any improvement with your patch
applied?
Several of us have reported a degenerate mode, that
I term as "tmf timeout", in which a aic94xx based card
becomes inoperable. Alas, the same hardware running another
OS does not exhibit that problem (or at least not as much).
> Signed-off-by: Al Viro <[email protected]>
> ---
> drivers/scsi/aic94xx/aic94xx_seq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/aic94xx/aic94xx_seq.c b/drivers/scsi/aic94xx/aic94xx_seq.c
> index d9b6da5..56e4b3b 100644
> --- a/drivers/scsi/aic94xx/aic94xx_seq.c
> +++ b/drivers/scsi/aic94xx/aic94xx_seq.c
> @@ -764,7 +764,7 @@ static void asd_init_lseq_mdp(struct asd
> asd_write_reg_word(asd_ha, LmSEQ_FIRST_INV_SCB_SITE(lseq),
> (u16)last_scb_site_no+1);
> asd_write_reg_word(asd_ha, LmSEQ_INTEN_SAVE(lseq),
> - (u16) LmM0INTEN_MASK & 0xFFFF0000 >> 16);
> + (u16) ((LmM0INTEN_MASK & 0xFFFF0000) >> 16));
> asd_write_reg_word(asd_ha, LmSEQ_INTEN_SAVE(lseq) + 2,
> (u16) LmM0INTEN_MASK & 0xFFFF);
> asd_write_reg_byte(asd_ha, LmSEQ_LINK_RST_FRM_LEN(lseq), 0);
BTW Luben was pointing out that the call you patched
and the following call can be combined into a less
trouble prone asd_write_reg_dword() call.
Doug Gilbert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
