Re: [PATCH]: Fix ALIGN() macro

[Kyle Moffett <mrmacman_g4@mac.com>]

On Sep 23, 2006, at 10:40:41, Herbert Xu wrote:
> diff --git a/crypto/hmac.c b/crypto/hmac.c
> index f403b69..d52b234 100644
> --- a/crypto/hmac.c
> +++ b/crypto/hmac.c
> @@ -98,7 +98,7 @@ static int hmac_init(struct hash_desc *p
>  	sg_set_buf(&tmp, ipad, bs);
>
>  	return unlikely(crypto_hash_init(&desc)) ?:
> -	       crypto_hash_update(&desc, &tmp, 1);
> +	       crypto_hash_update(&desc, &tmp, bs);
>  }
>
>  static int hmac_update(struct hash_desc *pdesc,

Quick question:  does "crypto_hash_init()" ever return anything other  
than 0 or 1?  If so this is a subtle bug, as "unlikely()" is  
implemented like this:

# define unlikely(x) __builtin_expect(!!(x), 0)

IMO any usage of likely/unlikely other than if(unlikely()), if(likely 
()) is probably a bug.

Cheers,
Kyle Moffett

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/