Pavel Machek wrote:
Hi!
+/*
+ * FIXME: very temporary implementation, just to prove the concept !!
+ */
+static int
+process_pwr_param(struct pm_core_point *opt, int op, char *param_name,
+ int va_arg)
Ok, so can we get final implementation? Parsing strings in drivers is
evil...
ok, i saw this your comment when you mentioned it for the first time and I
explicitly put it in TODO letter sent along with the patchset.
Can you instead of such implementation details try to review and give us your
comments if any on interfaces approach and namely on cpufreq/PowerOP integration
at cpufreq_driver layer; comments _based_ on the code. The issue with string
parsing does not affect cpufreq/PowerOP integration interfaces since currently I
keep going with parameter names(strings) interface for PowerOP Core regardless
of whether parsing will eventually occur - at PM Core or POwerOP Core.
Eugeny
Pavel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
