Re: kernel BUGs when removing largish files with the SLOB allocator

Matt Mackall <[email protected]> wrote:

> Not sure yet. There's only one user in nommu.c that shouldn't just be
> changed to ksize() that I can see, and that's the one in
> show_process_blocks(). That could test for VM_MAPPED_COPY and keep its
> hands off otherwise. 

Hmmm...  You're right.  However, note binfmt_elf_fdpic().  This calls ksize()
but should really call kobjsize().  It should not assume that the allocation
it's been given is of any particular type.  IIRC ksize() changed purpose at
some point.

> I can imagine situations where ->mmap returns pointers to something
> that's statically allocated anyway (XIP?), where kobjsize doesn't
> really make sense.

ramfs for example.  See get_unmapped_area() hooks, not mmap() hooks.

> Also, looks like the WARN_ON_SLACK code has rotten, result isn't
> defined in that function. Change it to base, perhaps?

Yeah.  It might be worth ditching it entirely too.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: Matt Mackall <[email protected]>

• References:
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: Matt Mackall <[email protected]>
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: Matt Mackall <[email protected]>
  • kernel BUGs when removing largish files with the SLOB allocator
    • From: Aubrey <[email protected]>
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: David Howells <[email protected]>
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: Aubrey <[email protected]>
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: David Howells <[email protected]>
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: Aubrey <[email protected]>
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: Nick Piggin <[email protected]>
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: Aubrey <[email protected]>
  • Re: kernel BUGs when removing largish files with the SLOB allocator
    • From: David Howells <[email protected]>

• Prev by Date: Re: [PATCH 2.6.18-rc5] PCI: sort device lists breadth-first
• Next by Date: Re: kernel BUGs when removing largish files with the SLOB allocator
• Previous by thread: Re: kernel BUGs when removing largish files with the SLOB allocator
• Next by thread: Re: kernel BUGs when removing largish files with the SLOB allocator
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]