On Mon, Sep 11, 2006 at 01:32:43AM +0400, Oleg Nesterov wrote:
> rcu_do_batch() decrements rdp->qlen with irqs enabled. This is not good,
> it can also be modified by call_rcu() from interrupt.
>
> Decrement ->qlen once with irqs disabled, after a main loop.
>
> Signed-off-by: Oleg Nesterov <[email protected]>
>
> --- rc6-mm1/kernel/rcupdate.c~ 2006-08-22 16:22:49.000000000 +0400
> +++ rc6-mm1/kernel/rcupdate.c 2006-09-11 01:24:17.000000000 +0400
> @@ -241,12 +241,16 @@ static void rcu_do_batch(struct rcu_data
> next = rdp->donelist = list->next;
> list->func(list);
> list = next;
> - rdp->qlen--;
> if (++count >= rdp->blimit)
> break;
> }
> +
> + local_irq_disable();
> + rdp->qlen -= count;
> + local_irq_enable();
> if (rdp->blimit == INT_MAX && rdp->qlen <= qlowmark)
> rdp->blimit = blimit;
> +
> if (!rdp->donelist)
> rdp->donetail = &rdp->donelist;
> else
Looks good to me.
Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
