Re: [PATCH 3/5] proc: Remove the hard coded inode numbers.

[ebiederm@xmission.com (Eric W. Biederman)]

Andrew Morton <akpm@osdl.org> writes:

> On Thu, 07 Sep 2006 11:55:59 -0600
> ebiederm@xmission.com (Eric W. Biederman) wrote:
>
>> Hey, thanks for the review.
>> 
>> I don't think so but a comment or two might be in order.
>> 
>> Calling filldir with the filename is the important part,
>> and the only real error is if filldir fails.
>> 
>> The rest of the logic is about populating and querying the
>> dcache so we can find our real inode number, if every reasonable
>> attempt to perform a dcache lookup fails I simply set the inode
>> number to 1 and use that in filldir.  It's wrong but at least
>> I report the file is there.
>> 
>> If I can find the dentry I lookup the inode and the inode
>> number and file type, and the dput the dentry.
>> 
>> If I can't lookup the dentry I attempt to create it.
>> instantiate will return a dentry or NULL if the dentry I preallocate
>> for it is good enough.
>
> I suspected it was something like that.
>
>> Is there something specific you are not seeing?
>
> Code comments explaining this stuff ;)

Sure.  Not every looks at how this is done in filesystems like
smbfs, and fat.

When I get a moment I will see if I can cook up a big fat comment.

Eric





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/