Re: [PATCH 2.6.18-rc4 1/5] ieee1394: sbp2: workaround for write protect bit of Initio firmware

[Linus Torvalds <torvalds@osdl.org>]

On Mon, 4 Sep 2006, Stefan Richter wrote:
> 
> I finally did my homework.

Thanks for looking into it.

> OS X' and Win XP's SBP-2 drivers send MODE SENSE (6) to RBC disks and to
> SBC disks. OS X sends MODE SENSE (10) to MMC devices, Win XP seems to
> send MODE SENSE (6).

I think that clinches it. If WinXP sends the 6-byte version, we should 
too, since that's effectively what pretty much everybody has tested with 
(yeah, Apple used to be the main firewire user, but I bet there have been 
more XP users over the last few years, it's not like it's unusual on PC's 
any more).

> So it should be safe to remove the use_10_for_ms flag in our sbp2 driver
> at least for RBC disks and SBC disks. I.e. the proposed "workaround for
> write protect bit of Initio firmware" will no longer be necessary.
> 
> Next steps for me to do:
>  - test all my devices with use_10_for_ms removed from sbp2,
>  - prepare patch as candidate for 2.6.19-rc.

Yeah, please send me a patch asap after 2.6.18, so that it can go in very 
early (regardless of anything else).

Btw, somebody should tell the Oracle Endpoint people to get their target 
client to support the 6-byte version too, no? Anybody who knows that team?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/