Re: [patch 4/9] Guest page hinting: volatile swap cache.

On Fri, 2006-09-01 at 07:58 -0700, Dave Hansen wrote:
> > +#if defined(CONFIG_PAGE_STATES)
> 
> This is a bit odd.  Why not use an #ifdef like the rest of the kernel?

Personal preference I guess. If you have multiple macros you want to
test for you need to use "#if defined(a) && defined(b)", there is no
equivalent #ifndef notation.

-- 
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [patch 4/9] Guest page hinting: volatile swap cache.
  - From: Martin Schwidefsky <[email protected]>
- Re: [patch 4/9] Guest page hinting: volatile swap cache.
  - From: Dave Hansen <[email protected]>

Prev by Date: Re: [NFS] [PATCH 019 of 19] knfsd: Register all RPC programs with portmapper by default
Next by Date: Re: [patch 1/9] Guest page hinting: unused / free pages.
Previous by thread: Re: [patch 4/9] Guest page hinting: volatile swap cache.
Next by thread: Re: [patch 4/9] Guest page hinting: volatile swap cache.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]