Re: [PATCH 2/3] kthread: update the s390 lcs driver to use kthread

[Christoph Hellwig <hch@infradead.org>]

On Thu, Aug 24, 2006 at 04:23:23PM -0500, Serge E. Hallyn wrote:
> Update the s390 Lan Channel Station Network Driver, which can be
> compiled as a module, to use kthread, rather than kernel_thread
> whose EXPORT_SYMBOL has been deprecated.

NACK.  Again a simple s/kernel_thread/kthread_run/ is not what we
need, you need to rething whats going on.  And the thread usage in
lcs is really bad :)

I'm not even sure why it creates all these short-lived threads,
but to fix this mess we might need a new function in kthread.c
that start a thread asynchronously so we can kill all the
workqueue mess in the various s390 net drivers and some other
places.

I'd suggest to start with getting a coherent description of what
those threads actually try to solve from the driver maintainer.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/