Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread

On Thu, Aug 24, 2006 at 04:22:42PM -0500, Serge E. Hallyn wrote:
> Update the s390 cooperative memory manager, which can be a module,
> to use kthread rather than kernel_thread, whose EXPORT is deprecated.
> 
> This patch compiles and boots fine, but I don't know how to really
> test the driver.

NACK.  Please do a real conversion to the kthread paradigm instead of
doctoring around the trivial bits that could be changed with a script.

Please use kthread_should_stop() and remove the cmm_thread_wait
waitqueue in favour of wake_up_process.  The timer useage could
probably be replaced with smart usage of schedule_timeout().
Also the code seems to miss a proper thread termination on module
removal.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread
    • From: "Serge E. Hallyn" <[email protected]>

• References:
  • [PATCH 1/3] kthread: update s390 cmm driver to use kthread
    • From: "Serge E. Hallyn" <[email protected]>

• Prev by Date: two bugletts on sparc - Dave Miller is always right, isn't he? :-)))
• Next by Date: Re: [PATCH 2/3] kthread: update the s390 lcs driver to use kthread
• Previous by thread: Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread
• Next by thread: Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]