Re: [PATCH 5/6] BC: kernel memory accounting (core)

Oleg Nesterov wrote:

On 08/23, Kirill Korotaev wrote:

+int bc_slab_charge(kmem_cache_t *cachep, void *objp, gfp_t flags)
+{
+	unsigned int size;
+	struct beancounter *bc, **slab_bcp;
+
+	bc = get_exec_bc();
+	if (bc == NULL)
+		return 0;

Is it possible to .exec_bc == NULL ?

If yes, why do we need init_bc? We can do 'set_exec_bc(NULL)' in __do_IRQ()
instead.

no, exec_bc can't be NULL. thanks for catching old hunks which historically exist
due to old times when host system was not accounted (bc was NULL).

Thanks,
Kirill
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] BC: resource beancounters (v2)
    • From: Kirill Korotaev <[email protected]>
  • [PATCH 5/6] BC: kernel memory accounting (core)
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH 5/6] BC: kernel memory accounting (core)
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: [PATCH 0/4] Compile kernel with -fwhole-program --combine
• Next by Date: Re: [PATCH 0/4] Compile kernel with -fwhole-program --combine
• Previous by thread: Re: [PATCH 5/6] BC: kernel memory accounting (core)
• Next by thread: [PATCH 6/6] BC: kernel memory accounting (marks)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]