Serial custom speed deprecated?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From
http://www.kernel.org/pub/linux/kernel/v2.5/ChangeLog-2.5.64

"<[email protected]>
	Complain about setting custom speed or divisor on serial ports."

And the relevant patch hunk:
@@ -832,8 +826,17 @@
                goto exit;
        if (info->flags & UIF_INITIALIZED) {
                if (((old_flags ^ port->flags) & UPF_SPD_MASK) ||
-                   old_custom_divisor != port->custom_divisor)
+                   old_custom_divisor != port->custom_divisor) {
+                       /* If they're setting up a custom divisor or speed,
+                        * instead of clearing it, then bitch about it. No
+                        * need to rate-limit; it's CAP_SYS_ADMIN only. */
+                       if (port->flags & UPF_SPD_MASK) {
+                               printk(KERN_NOTICE "%s sets custom speed on %s%d. This is deprecated.\n",
+                                      current->comm, info->tty->driver.name,
+                                      info->port->line);
+                       }
                        uart_change_speed(info, NULL);
+               }
        } else
                retval = uart_startup(info, 1);
  exit:

If custom speeds are deprecated, what's the new method for setting
them? Specifically, how can the SPD_CUST functionality be accomplished
without that flag? I've checked 2.5.64 and 2.6.17, and don't see how
it is possible.

..Stu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux