Re: drivers/media/dvb/dvb-usb/dibusb-mb.c: NULL dereference

[Patrick Boettcher <patrick.boettcher@desy.de>]

Hi Adrian,

On Tue, 15 Aug 2006, Adrian Bunk wrote:

> The Coverity checker spotted the following "we dereference d->fe only 
> when we know it's NULL" bug:
> 
> <--  snip  -->
> 
> ...
> static int dibusb_dib3000mb_frontend_attach(struct dvb_usb_device *d)
> {
> ...
>         if ((d->fe = dib3000mb_attach(&demod_cfg,&d->i2c_adap,&st->ops)) == NULL) {
>                 d->fe->ops.tuner_ops.init = dvb_usb_tuner_init_i2c;
>                 d->fe->ops.tuner_ops.set_params = dvb_usb_tuner_set_params_i2c;
>                 return -ENODEV;
>         }
> ...
> 
> <--  snip  -->

Oops, this one was introduced in rev 3124 of the v4l-dvb repository when 
adding tuner_ops.

Mauro, can you please pull from http://linuxtv.org/hg/~pb/v4l-dvb to get 
the fix.

For the others: the changeset is here: 

http://linuxtv.org/hg/~pb/v4l-dvb?cmd=changeset;node=ac1c589c56fc018f14fdf74c274d8438a8566b69;style=raw

regards,
Patrick.

--
  Mail: patrick.boettcher@desy.de
  WWW:  http://www.wi-bw.tfh-wildau.de/~pboettch/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/