Re: [PATCH] fuse: fix error case in fuse_readpages

[Andrew Morton <akpm@osdl.org>]

On Thu, 10 Aug 2006 10:45:59 +0200
Miklos Szeredi <miklos@szeredi.hu> wrote:

> > > Thanks Alex.
> > > 
> > > -mm also needs s/page_cache_release/read_cache_pages_release_page/ on patch
> > > 
> > > --
> > > From: Alexander Zarochentsev <zam@namesys.com>
> > > 
> > > Don't let fuse_readpages leave the @pages list not empty when exiting
> > > on error.
> > > 
> > 
> > hm, OK.
> > 
> > > +extern void readpages_cleanup_helper(struct list_head *);
> > 
> > Can we think of a better name?  I mean, all it does is throw away a list of
> > pages.  The caller doesn't _have_ to be using it within the context of
> > read_cache_pages().  put_pages()?  put_pages_list()?
> 
> So what's up with read_cache_pages_release_page() in -mm, which seems
> to be rather specific to read_cache_pages()?
> 

That's part of the readahead patches.  Don't look at that ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/