Hi Komal,
This one ended up in my spam box once again, although with a lower
score (using the proper type for the attachement seems to have helped.)
Maybe try with a shorter list of recipients next time, and add the name
of people before their address.
> Attached the updated patch as per the review comments on #3 patch.
>
> Please consider it for the inclusion.
Looks good, I'll take it. One remaining objection:
> +static int omap_i2c_get_clocks(struct omap_i2c_dev *dev)
> +{
> + if (cpu_is_omap16xx() || cpu_is_omap24xx()) {
> + dev->iclk = clk_get(dev->dev, "i2c_ick");
> + if (IS_ERR(dev->iclk)) {
> + dev->iclk = NULL;
> + return -ENODEV;
> + }
> + }
> +
> + dev->fclk = clk_get(dev->dev, "i2c_fck");
> + if (IS_ERR(dev->fclk)) {
> + if (dev->iclk != NULL) {
> + clk_put(dev->iclk);
> + dev->iclk = NULL;
> + return -ENODEV;
I think this return shouldn't be there.
> + }
> + dev->fclk = NULL;
> + return -ENODEV;
> + }
> +
> + return 0;
> +}
I'll fix it myself if you agree, so that you don't have to resend a
patch. Thanks for the good work! I'll send the patch upstream at the
end of the week, so it should show in -mm soon.
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
