Re: [KJ] [patch] fix common mistake in polling loops

G'day,

On 8/10/06, Andrew James Wade <[email protected]> wrote:

You're getting duplicated code there. That'll be an issue in more
complex loops. How about:

unsigned long timeout = jiffies + HZ/2;
int timeup = 0;

for (;;;) {
        if (ready())
                return 0;
        if (timeup)
                break;
        msleep(10);
        timeup = time_after(timeout, jiffies);
};
... timeout ...

Nice, looks better than my idea.
Removes the code duplication and reduces complexity(a little) at the
cost of an extra variable.

The only Nitpick is

- int timeup = 0;
+ unsigned char timeup = 0;

Andrew Wade

Darren J.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch] fix common mistake in polling loops
    • From: "Zed 0xff" <[email protected]>
  • Re: [KJ] [patch] fix common mistake in polling loops
    • From: "Darren Jenkins" <[email protected]>
  • Re: [KJ] [patch] fix common mistake in polling loops
    • From: "Om N." <[email protected]>
  • Re: [KJ] [patch] fix common mistake in polling loops
    • From: Andrew James Wade <[email protected]>

• Prev by Date: [PATCH 1/2] acpi,backlight: MSI S270 laptop support - ec_transaction()
• Next by Date: [PATCH 0/5] Forking ext4 filesystem and JBD2
• Previous by thread: Re: [KJ] [patch] fix common mistake in polling loops
• Next by thread: Re: [KJ] [patch] fix common mistake in polling loops
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]