Re: [PATCH 04/10] -mm clocksource: add some new API calls

On Fri, 2006-08-04 at 12:28 -0700, Daniel Walker wrote:
> > >  int clocksource_register(struct clocksource *c)
> > >  {
> > >  	int ret = 0;
> > >  	unsigned long flags;
> > >  
> > > +	if (unlikely(!c))
> > > +		return -EINVAL;
> > > +
> > 
> > I'm not sure I understand the need for this. Is it really likely someone
> > would pass NULL to clocksource_register()?
> 
> Not likely, I was just covering all possibilities.. It might be better
> as a BUG_ON() actually.

BUG_ON is the only thing, which can be correct here. Registering a NULL
clocksource simply is a bug, but even the BUG_ON is overkill here. 

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 00/10] -mm generic clocksoure API
    • From: [email protected]
  • [PATCH 04/10] -mm clocksource: add some new API calls
    • From: [email protected]
  • Re: [PATCH 04/10] -mm clocksource: add some new API calls
    • From: john stultz <[email protected]>
  • Re: [PATCH 04/10] -mm clocksource: add some new API calls
    • From: Daniel Walker <[email protected]>

• Prev by Date: Re: problems with e1000 and jumboframes
• Next by Date: Re: [Fastboot] [CFT] ELF Relocatable x86 and x86_64 bzImages
• Previous by thread: Re: [PATCH 04/10] -mm clocksource: add some new API calls
• Next by thread: [PATCH 06/10] -mm clocksource: add block notifier
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]