Re: [PATCH] fix dubious segment register clear in cpu_init()

On Friday 04 August 2006 01:49, Jeremy Fitzhardinge wrote:
> Fix a very dubious piece of code in
> arch/i386/kernel/cpu/common.c:cpu_init().  This clears out %fs and
> %gs, but clobbers %eax in the process without telling gcc.  It turns
> out that gcc happens to be not using %eax at that point anyway so it
> doesn't matter much, but it looks like a bomb waiting to go off.
> 
> This does end up saving an instruction, because gcc wants %eax==0 for
> the set_debugreg()s below.

Added thanks

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fix dubious segment register clear in cpu_init()
    • From: Jeremy Fitzhardinge <[email protected]>

• Prev by Date: Re: [Lhms-devel] [PATCH] memory hotadd fixes [4/5] avoid check in acpi
• Next by Date: Re: [PATCH -rt DO NOT APPLY] Fix for tg3 networking lockup
• Previous by thread: [PATCH] fix dubious segment register clear in cpu_init()
• Next by thread: [PATCH 001/001] I2C: AD7414 I2C chip driver for Linux-2.6.17.7
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]