Re: [PATCH] x86_64 built-in command line

[Andi Kleen <ak@suse.de>]

On Monday 31 July 2006 22:41, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >   
> >> +#ifdef CONFIG_CMDLINE_BOOL
> >> +	strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> >> +#endif
> > 
> > I think I would prefer a strcat.
> > 
> > Also you should describe the exact behaviour (override/append) in Kconfig help.
> > 
> 
> In the i386 thread, Matt described having a firmware bootloader which 
> passes bogus parameters.  For that case, it would make sense to have a 
> non-default CONFIG option to have override rather than conjoined (and I 
> maintain that the built-in command line should be prepended.)

Is that boot loader common? What's its name? 
If not I would prefer that he keeps the one liner patch to deal
with that private.

For generic semantics strcat (or possible prepend) is probably better.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/