Re: [PATCH] x86_64 built-in command line

Andi Kleen wrote:

+#ifdef CONFIG_CMDLINE_BOOL
+	strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
+#endif

I think I would prefer a strcat.

Also you should describe the exact behaviour (override/append) in Kconfig help.

In the i386 thread, Matt described having a firmware bootloader which passes bogus parameters. For that case, it would make sense to have a non-default CONFIG option to have override rather than conjoined (and I maintain that the built-in command line should be prepended.)

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] x86_64 built-in command line
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH] x86_64 built-in command line
    • From: Matt Mackall <[email protected]>
  • Re: [PATCH] x86_64 built-in command line
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [patch 2/3] add CSA accounting to taskstats
• Next by Date: Re: [patch 3/3] convert CONFIG tag for a few accounting data used by CSA
• Previous by thread: Re: [PATCH] x86_64 built-in command line
• Next by thread: Re: [PATCH] x86_64 built-in command line
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]