Jesper Juhl <[email protected]> wrote:
> On 30/07/06, Paul Jackson <[email protected]> wrote:
> > Jesper wrote:
> > > - cprint("%s", filename);
> > > + cprint("%s", config_filename);
> >
> > Something seems strange here to me. It looks like you are sometimes
> > resolving the shadowed symbols by making the more local symbol have the
> > longer name.
[...]
> > instr
>
> I don't recall using that variable name - I believe you mean 'intr'
> for interrupt that I used in place of 'irq'.
Please don't. If people are accustomed to irq, they will start wondering
what intr is all about (or what the difference is, etc).
> > up
> I'd *love* to change this one - and down() as well - to up_sem() &
> down_sem().
Just too bad that there aren't semaphores anymore... and I can't find up()
down() in the headers anyway?
> But, making that change would be a pretty major and
> somewhat disruptive api change, so I opted instead to change the local
> variable names. I plan to introduce a sepperate patch set later on
> that adds up_sem()/down_sem() wrappers around up()/down(), deprecate
> the old names and add an entry to feature-removal.txt - but doing it
> now as part of the -Wshadow cleanup would be too much pain.
Why not leave them alone for the time being then, and clean up in one sweep
later on?
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
