Re: [PATCH 005 of 9] md: Replace magic numbers in sb_dirty with well defined bit flags

Hi Neil,

I think the names in this patch don't match the description at all.
May I suggest different ones?

On Monday, 31. July 2006 09:32, NeilBrown wrote:
> 
> Instead of magic numbers (0,1,2,3) in sb_dirty, we have
> some flags instead:
> MD_CHANGE_DEVS
>    Some device state has changed requiring superblock update
>    on all devices.

MD_SB_STALE or MD_SB_NEED_UPDATE

> MD_CHANGE_CLEAN
>    The array has transitions from 'clean' to 'dirty' or back,
>    requiring a superblock update on active devices, but possibly
>    not on spares

Maybe split this into MD_SB_DIRTY and MD_SB_CLEAN ?

> MD_CHANGE_PENDING
>    A superblock update is underway.  

MD_SB_PENDING_UPDATE


Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 005 of 9] md: Replace magic numbers in sb_dirty with well defined bit flags
  - From: Bill Davidsen <[email protected]>

References:
- [PATCH 000 of 9] md: Introduction - assorted cleanup and minor fixes
  - From: NeilBrown <[email protected]>
- [PATCH 005 of 9] md: Replace magic numbers in sb_dirty with well defined bit flags
  - From: NeilBrown <[email protected]>

Prev by Date: PROBLEM: OSS/MAD16 not available to compilation of kernel
Next by Date: Re: [PATCH 01/12] making the kernel -Wshadow clean - fix mconf
Previous by thread: [PATCH 005 of 9] md: Replace magic numbers in sb_dirty with well defined bit flags
Next by thread: Re: [PATCH 005 of 9] md: Replace magic numbers in sb_dirty with well defined bit flags
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]