Re: Require mmap handler for a.out executables

[Marcel Holtmann <marcel@holtmann.org>]

Hi Linus,

> > > diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> > > index f312103..5638acf 100644
> > > --- a/fs/binfmt_aout.c
> > > +++ b/fs/binfmt_aout.c
> > > @@ -278,6 +278,9 @@ static int load_aout_binary(struct linux
> > >  		return -ENOEXEC;
> > >  	}
> > >  
> > > +	if (!bprm->file->f_op || !bprm->file->f_op->mmap)
> > > +		return -ENOEXEC;
> > > +
> > 
> > These checks need a big comment explanining why they are there, else people
> > will remove them again by accident.
> 
> Since we fixed the /proc problem in a different way, I decided that it 
> might be best to leave the a.out stuff alone, at least for now. It is 
> conceivable that somebody actually might be using executables on some 
> strange filesystem that doesn't support mmap, although I can't for the 
> moment think of any good reason. 

what do think about giving this a spin in -mm for some time and see if
it will break for somebody.

Andrew, please include it.

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/