Re: Require mmap handler for a.out executables

> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> index f312103..5638acf 100644
> --- a/fs/binfmt_aout.c
> +++ b/fs/binfmt_aout.c
> @@ -278,6 +278,9 @@ static int load_aout_binary(struct linux
>  		return -ENOEXEC;
>  	}
>  
> +	if (!bprm->file->f_op || !bprm->file->f_op->mmap)
> +		return -ENOEXEC;
> +

These checks need a big comment explanining why they are there, else people
will remove them again by accident.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Require mmap handler for a.out executables
    • From: Eugene Teo <[email protected]>
  • Re: Require mmap handler for a.out executables
    • From: Linus Torvalds <[email protected]>

• References:
  • Require mmap handler for a.out executables
    • From: Marcel Holtmann <[email protected]>

• Prev by Date: Re: hwrng on 82801EB/ER (ICH5/ICH5R) fails rngtest checks
• Next by Date: Re: Generic battery interface
• Previous by thread: Require mmap handler for a.out executables
• Next by thread: Re: Require mmap handler for a.out executables
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]