Re: [patch] slab: always follow arch requested alignments

On Wed, 26 Jul 2006, Manfred Spraul wrote:

> There are two different types of alignment:
> - SLAB_HWCACHE_ALIGN: it's a recommendation, it's regularly ignored.
> - the align parameter, or ARCH_SLAB_MINALIGN: It's mandatory. For example the
> pgd structures must be 4 kB aligned, it's required by the hardware. And I
> think there was (is?) a structure where ptr & ~(size-1) was used to find the
> start of the structure.

I agree with the above if there is an issue there then lets fix it.

> Thus the patch is correct, it's a bug in the slab allocator. If HWCACHE_ALIGN
> is set, then the allocator ignores align or ARCH_SLAB_MINALIGN.

But then Heiko does not want to set ARCH_SLAB_MINALIGN at all. This is not 
the issue we are discussing. In the DEBUG case he wants 
ARCH_KMALLOC_MINALIGN to be enforced even if ARCH_SLAB_MINALIGN is not 
set.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch] slab: always follow arch requested alignments
    • From: Heiko Carstens <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Pekka J Enberg <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Christoph Lameter <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Pekka J Enberg <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Pekka J Enberg <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Christoph Lameter <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: "Pekka Enberg" <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Christoph Lameter <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Pekka J Enberg <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Christoph Lameter <[email protected]>
  • Re: Re: [patch] slab: always follow arch requested alignments
    • From: "Pekka Enberg" <[email protected]>
  • Re: [patch] slab: always follow arch requested alignments
    • From: Manfred Spraul <[email protected]>

• Prev by Date: [PATCH] [xfs] Add lock annotations to xfs_trans_update_ail and xfs_trans_delete_ail
• Next by Date: OLS BoF on Resource Management - some notes
• Previous by thread: Re: [patch] slab: always follow arch requested alignments
• Next by thread: Re: [patch] slab: always follow arch requested alignments
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]