Re: [patch] slab: always follow arch requested alignments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pekka Enberg wrote:

Hi Christoph,

On 7/26/06, Christoph Lameter <[email protected]> wrote:

We intentionally discard the caller mandated alignment for debugging
purposes.


There are two different types of alignment:
- SLAB_HWCACHE_ALIGN: it's a recommendation, it's regularly ignored.
- the align parameter, or ARCH_SLAB_MINALIGN: It's mandatory. For example the pgd structures must be 4 kB aligned, it's required by the hardware. And I think there was (is?) a structure where ptr & ~(size-1) was used to find the start of the structure.

Thus the patch is correct, it's a bug in the slab allocator. If HWCACHE_ALIGN is set, then the allocator ignores align or ARCH_SLAB_MINALIGN.

--
   Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux