Re: [PATCH 2/2] usbhid: HID device simple driver interface

[Josef Sipek <jsipek@fsl.cs.sunysb.edu>]

On Wed, Jul 26, 2006 at 06:41:53PM +0800, liyu wrote:
> ==================================
> HID device simple driver interface
> ==================================
>  
>     This patch include the header file for this API.
> 
>     I am sorry for sendding patches in the attachment, beacause of my
> mail client always break TAB into some spaces.
> 
>     Good luck.
> 
> -Liyu
> 

First of all, you should include your patches inline. That way one can
easily comment on them. I only quickly glanced at it, and I am not sure
about why you need the additional list_ macros. Also, several of your macros
do something like this:

+#define hidinput_simple_driver_setup_usage(hid) \
+do {\
+       if (hid->simple) {\
+               hid->simple->flags |= HIDINPUT_SIMPLE_SETUP_USAGE; \
+               hidinput_simple_driver_configure_usage(hid); \
+       }\
+} while (0)

You should use (hid) instead of hid. Because of how the pre-processor works.

Josef "Jeff" Sipek.

-- 
If I have trouble installing Linux, something is wrong. Very wrong.
		- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/