Re: + spinlock_debug-dont-recompute-jiffies_per_loop.patch added to -mm tree

* Dave Jones <[email protected]> wrote:

>  > iteration limit, gets recomputed every time.  Caching it explicitly 
>  > prevents that.
> 
> What is the purpose of those __delays being there at all ? Seems odd 
> to be waiting that long when the spinlock could become available a lot 
> sooner.  (These also make spinlock debug really painful on boxes with 
> huge numbers of CPUs).

the debug code has to figure out when to trigger a deadlock warning 
message. If we are looping in a deadlock with irqs disabled on all CPUs, 
there's nothing that advances jiffies. The TSC is not reliable. The 
thing that remains is to use __delay(1). We could calibrate the loop 
separately perhaps?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: + spinlock_debug-dont-recompute-jiffies_per_loop.patch added to -mm tree
    • From: Dave Jones <[email protected]>

• Prev by Date: Re: [PATCH] RTC: Add mmap method to rtc character driver
• Next by Date: Re: the " 'official' point of view" expressed by kernelnewbies.org regarding reiser4 inclusion
• Previous by thread: Re: + spinlock_debug-dont-recompute-jiffies_per_loop.patch added to -mm tree
• Next by thread: [PATCH] Stop calling phy_stop_interrupts() twice
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]