[PATCH] [coda] Remove incorrect unlock_kernel from allocation failure path in coda_open

Commit 398c53a757702e1e3a7a2c24860c7ad26acb53ed (in the historical GIT tree)
moved the lock_kernel() in coda_open after the allocation of a coda_file_info
struct, but left an unlock_kernel() in the allocation failure error path;
remove it.

Signed-off-by: Josh Triplett <[email protected]>
---
 fs/coda/file.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/fs/coda/file.c b/fs/coda/file.c
index cc66c68..dbfbcfa 100644
--- a/fs/coda/file.c
+++ b/fs/coda/file.c
@@ -136,10 +136,8 @@ int coda_open(struct inode *coda_inode, 
 	coda_vfs_stat.open++;
 
 	cfi = kmalloc(sizeof(struct coda_file_info), GFP_KERNEL);
-	if (!cfi) {
-		unlock_kernel();
+	if (!cfi)
 		return -ENOMEM;
-	}
 
 	lock_kernel();
 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] [coda] Remove incorrect unlock_kernel from allocation failure path in coda_open
    • From: Jan Harkes <[email protected]>

• Prev by Date: Re: the " 'official' point of view" expressed by kernelnewbies.org regarding reiser4 inclusion
• Next by Date: Re: [patch] [resend] Fix swsusp with PNP BIOS
• Previous by thread: Question about Git tree methodology.
• Next by thread: Re: [PATCH] [coda] Remove incorrect unlock_kernel from allocation failure path in coda_open
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]