Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

Jeff Garzik wrote:

Tomasz Kłoczko wrote:

Moment .. are you want to say something like "keep commont coding style can't be maintained by tool" ?

Yes and no.

Even if indent watches on to small coding style emenets still I don't see why using this tool isn't one of the current ement of release procedure (?).

indent isn't perfect, _especially_ where C99 comes into the picture.

And running indent across the tree pre-release would (a) create a ton of noise before each release, and (b) undo perfectly valid, readable formatting.

scripts/Lindent exists and gets used, but it is not perfect.

Tomasz,

yes, we have scripts/Lindent, but it cannot and is not supposed to solve all style issues. Coding style is about _much_ more than whitespace. It includes sensible names, usage of language features...

Furthermore, much of this thread revolved around style issues where a common coding style is not fully established in the first place.

--
Stefan Richter
-=====-=-==- -=== =-===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Tomasz Kłoczko <[email protected]>

• References:
  • [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: [email protected] (Panagiotis Issaris)
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Rolf Eike Beer <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: "Pekka Enberg" <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Stefan Richter <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: "Jesper Juhl" <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Panagiotis Issaris <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Pekka J Enberg <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Stefan Richter <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Tomasz Kłoczko <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Stefan Richter <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Tomasz Kłoczko <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: Debugging APM - cat /proc/apm produces oops
• Next by Date: Re: Graphic: userspace headers interdependencies
• Previous by thread: Re: Lindent cleanup (was Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.)
• Next by thread: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]