Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.

Pekka J Enberg wrote:
> At least Andrew seems to prefer cleaning up in the same patch. Anyway, I 
> don't think Jeff meant that you shouldn't do any cleanups, but that you 
> should try to respect the existing style as much possible.

First and foremost, respect that the Linux sources need to have a
minimum level of stylistic uniformity.

> There are 
> things that are almost generally agreed upon, such as removal of redundant 
> typecasts, redundant wrappers, and moving assignment out of if statement 
> expression. Formatting and the dreaded sizeof thing, however, 
> are not, so it is best to keep them as-is.

Contributors can't know what the (supposed) _agreements_ are.

Contributors can only know what the _documented conventions_ are.
-- 
Stefan Richter
-=====-=-==- -=== =--==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.
    • From: Pekka J Enberg <[email protected]>

• References:
  • [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: [email protected] (Panagiotis Issaris)
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Rolf Eike Beer <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: "Pekka Enberg" <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.
    • From: Panagiotis Issaris <[email protected]>
  • Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.
    • From: Pekka J Enberg <[email protected]>

• Prev by Date: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
• Next by Date: Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
• Previous by thread: Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.
• Next by thread: Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]