On 7/17/06, Michael Krufky <[email protected]> wrote:
Axel Thimm wrote:
> latest hg fails on > 2.6.17 due to video_device_create_file being void
> but still being asked for a return value in bttv-driver.c
>
> linux/drivers/media/video/bt8xx/bttv-driver.c:
>
> 3963 #if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,17)
> 3964 ret = video_device_create_file(btv->video_dev, class_device_attr_card);
> 3965 if (ret < 0)
>
>
> linux/include/media/v4l2-dev.h:
>
> 379 static inline void
> 380 video_device_create_file(struct video_device *vfd,
> 381 struct class_device_attribute *attr)
> 382 {
>
<snip>
Hmmm... This was caused by the "Check all __must_check warnings in
bttv." patch from Randy Dunlap (cc's from original thread added)
I am aware that this was done for various reasons of sanity checking,
however, we cannot check the return value of a void ;-)
For the sanity checking, I don't think video_device_create_file()
should be a void function. It probably should return
class_device_create_file()'s return value, no? As it can fail...
Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
