Re: functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]

On Monday 10 July 2006 18:45, Michael Tokarev wrote:
> In such cases when a routine returns 0 on error, I usually write
> it this way:
> 
>    if (request_resource() != 0)
>      fail()
> 


Many write:

	error = do_something();
	if (error) {
		...
	}

And then it really obvious.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix a memory leak in the i386 setup code
    • From: Catalin Marinas <[email protected]>
  • functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]
    • From: Michael Tokarev <[email protected]>

• Prev by Date: Re: [RFC: -mm patch] drivers/char/scx200_gpio.c: make code static
• Next by Date: Re: [PATCH -mm 5/7] add user namespace
• Previous by thread: Re: functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]
• Next by thread: Error in git pull
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]