Re: functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]

Michael Tokarev wrote:
[]
> Ofcourse, later you understand that do_something() returns 0
> on failure, and the code is correct.  But the first impression
> (again, for me anyway) is that it's wrong.
> 
> In such cases when a routine returns 0 on error, I usually write
> it this way:
....
s/error/success/g.  Blah ;)
> 
>    if (request_resource() != 0)
>      fail()
[..]
/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] Fix a memory leak in the i386 setup code
  - From: Catalin Marinas <[email protected]>
- functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]
  - From: Michael Tokarev <[email protected]>

Prev by Date: Re: [Alsa-devel] OSS driver removal, 2nd round (v2)
Next by Date: Re: [BUG] APM resume breakage from 2.6.18-rc1 clocksource changes
Previous by thread: functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]
Next by thread: Re: functions returning 0 on success [was: [PATCH] Fix a memory leak in the i386 setup code]
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]