Re: annoying frequent overcurrent messages.

["Ray Lee" <madrabbit@gmail.com>]

On 7/12/06, Alan Stern <stern@rowland.harvard.edu> wrote:
> > Then the logging of the 'all cleared up' message would be better if it
> > had a bit of hysteresis to it -- the good state is noticed, but don't
> > log it as such until it hangs out there for a while and has had a
> > chance to quiesce.
>
> You didn't read what I wrote -- there _is_ no "all cleared up" message.

You're right, I didn't -- my apologies. However:

> > That's almost exactly how the driver behaves currently -- the message is
> > printed just once when the state is first noticed.  Nothing is printed
> > when the state is cleared, and nothing gets printed repeatedly during the
> > problem period.  But then the problem recurs very quickly.

If you change my wording from "all cleared up message" to "clearing
the internal state that keeps track of whether we're still in an
overcurrent situation" then my suggestion still makes sense. In short,
don't believe we're out of the overcurrent state until a bit of time
passes.

Before we go any further, let's make sure my suggestion could even fix
anything for Dave. Dave? How often are these messages printed? Do they
come in clumps? Or are they periodic? In other words, would a bit of
hystersis in the state clearing code remove most of the messages for
you? Or am I just stirring up trouble?

Ray
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/