Re: [PATCH] Add memcpy_cachebypass, a copy routine that tries to keep cache pressure down

Bryan O'Sullivan <[email protected]> writes:
> + * memcpy_cachebypass - memcpy-compatible copy routine, using streaming loads
> + * @dest: destination address
> + * @src: source address (will not be cached)
> + * @count: number of bytes to copy
> + *
> + * Use streaming loads and normal stores for a special-case copy where
> + * we know we won't be reading the source again, but will be reading the
> + * destination again soon.
> + */

For what CPU did you optimize that function?   Comment missing for that.
Also the comment should state that you're caching the target.
Also I trust you ran it through a comprehensive memcpy-all-cases tester?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] Add memcpy_cachebypass, a copy routine that tries to keep cache pressure down
  - From: "Bryan O'Sullivan" <[email protected]>

Prev by Date: Re: [PATCH 00/10] Kernel memory leak detector 0.8
Next by Date: Re: [PATCH 00/10] Kernel memory leak detector 0.8
Previous by thread: Re: [PATCH] Add memcpy_cachebypass, a copy routine that tries to keep cache pressure down
Next by thread: [PATCH] net48xx LED cleanups
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]