[patch] Re: Magic Alt-SysRq change in 2.6.18-rc1

[Pavel Machek <pavel@ucw.cz>]

On Wed 2006-07-12 00:21:31, Roman Zippel wrote:
> Hi,
> 
> On Tue, 11 Jul 2006, Pavel Machek wrote:
> 
> > > Apparently it changes existing well documented behaviour, which is a 
> > > really bad idea.
> > 
> > _well documented_? Where was it documented? Anyway, 2.6.17 behaviour
> > does not work on _many_ keyboards, like for example thinkpad x32...
> 
> Documentation/sysrq.txt and this was working on _many_ more keyboards just 
> fine.
> The fact is this patch changes existing behaviour, it either needs to be
> fixed or reverted. Adding new features is one thing, breaking existing 
> features is not acceptable without a very good reason.

Your "well documented" is sentence "you may have better luck
with"... okay, but we now have better sentence. Document it better.

BTW I believe that original way (alt down, sysrq down, b down) still
works before and after the patch.

Here's patch that updates docs with now-working trick.

Signed-off-by: Pavel Machek <pavel@suse.cz> 

diff --git a/Documentation/sysrq.txt b/Documentation/sysrq.txt
index e0188a2..58e04c0 100644
--- a/Documentation/sysrq.txt
+++ b/Documentation/sysrq.txt
@@ -43,7 +43,7 @@ On x86   - You press the key combo 'ALT-
            keyboards may not have a key labeled 'SysRq'. The 'SysRq' key is
            also known as the 'Print Screen' key. Also some keyboards cannot
 	   handle so many keys being pressed at the same time, so you might
-	   have better luck with "press Alt", "press SysRq", "release Alt",
+	   have better luck with "press Alt", "press SysRq", "release SysRq",
 	   "press <command key>", release everything.
 
 On SPARC - You press 'ALT-STOP-<command key>', I believe.


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/