On 11.07.2006 23:51, Andrew Morton wrote: > Tilman Schmidt <[email protected]> wrote: > >>- class_device_create_file(cs->class, &class_device_attr_cidmode); >>+ if (class_device_create_file(cs->class, &class_device_attr_cidmode)) >>+ dev_warn(cs->dev, "could not create sysfs attribute\n"); > > With this change we'll emit a warning (actually it's an error - I'll make > it dev_err(), OK?) Fine with me. It's not fatal to the driver which is quite capable of operating without that sysfs file, but ok, it *is* an error, and in fact, if class_device_create_file() fails there must be something seriously wrong. > and then we'll continue execution, pretending that the > sysfs file actually got registered. Later, we'll try to unregister a > not-registered sysfs file. Well, from my reading of the source, class_device_remove_file() should be able to cope with that. The alternative would be to save off the fact that the original creation failed somewhere in the driver data, for the sole purpose of avoiding calling class_device_remove_file() for it later. -- Tilman Schmidt E-Mail: [email protected] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
Attachment:
signature.asc
Description: OpenPGP digital signature
- References:
- Re: [mm Patch] isdn4linux: Gigaset driver: fix __must_check warning
- From: Andrew Morton <[email protected]>
- Re: [mm Patch] isdn4linux: Gigaset driver: fix __must_check warning
- Prev by Date: boot hangs with SMP, USB storage, and ACPI
- Next by Date: [patch] Re: Magic Alt-SysRq change in 2.6.18-rc1
- Previous by thread: Re: [mm Patch] isdn4linux: Gigaset driver: fix __must_check warning
- Next by thread: [PATCH 2.6.17] ata_piix device probe fixes
- Index(es):
 |