On Mon, Jul 10, 2006 at 10:58:49AM +0200, Ingo Molnar wrote:
>
> * David Brownell <[email protected]> wrote:
>
> > It's not just "normal" mode operation that needs refcounting for the
> > {en,dis}able_irq() calls ... "wakeup" mode calls need it too, for the
> > very same reasons.
> >
> > This patch adds that refcounting. I expect that some ARM drivers will
> > be triggering the new warning, but this call isn't yet widely used.
> > (Which is probably why the bug has lingered this long...)
>
> Acked-by: Ingo Molnar <[email protected]>
>
> we should also add disable_irq_wake() / enable_irq_wake() APIs and start
> migrating most ARM users over to the new APIs, agreed? That makes the
> APIs more symmetric and the code more readable too.
That _is_ the API anyway. set_irq_wake() was never intended to be called
directly from drivers.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
