On July 05 at 23:01 EDT, Randy.Dunlap hastily scribbled: > On Wed, 5 Jul 2006 22:48:17 -0400 Thomas Tuttle wrote: > > > Here is a new version of the patch, incorporating code style tips from > > Randy Dunlap <[email protected]>, and based on 2.6.17-git25, rather > > than 2.6.17.1. > > > > I noticed that there's a Heartbeat LED trigger in the git version. I > > hope this isn't too similar. > > I missed at least one thing: > > Don't #include <linux/config.h> > That is done automatically now by Kbuild. Source files > should not do it. (you could wait to see if there are other comments. :) > > --- > ~Randy Are you sure? Will it rebuild a file if a config entry is changed that is simply mentioned in an #ifdef? Is this a recent change? It wasn't working this way in 2.6.17.1--it automatically noticed changes to the config of the file itself, but not to config symbols tested using #ifdef.
Attachment:
pgpR0QhMBnJjN.pgp
Description: PGP signature
- Follow-Ups:
- Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
- From: "Randy.Dunlap" <[email protected]>
- Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
- References:
- Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
- From: "Thomas Tuttle" <[email protected]>
- Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
- From: "Randy.Dunlap" <[email protected]>
- Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
- Prev by Date: [PATCH] Fix poll() nfds check.
- Next by Date: Re: O_TARGET
- Previous by thread: Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
- Next by thread: Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
- Index(es):
 |