Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)

On Wed, 5 Jul 2006 22:48:17 -0400 Thomas Tuttle wrote:

> Here is a new version of the patch, incorporating code style tips from
> Randy Dunlap <[email protected]>, and based on 2.6.17-git25, rather
> than 2.6.17.1.
> 
> I noticed that there's a Heartbeat LED trigger in the git version.  I
> hope this isn't too similar.

I missed at least one thing:

Don't #include <linux/config.h>
That is done automatically now by Kbuild.  Source files
should not do it.  (you could wait to see if there are other comments. :)

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
    • From: Thomas Tuttle <[email protected]>

• References:
  • Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
    • From: "Thomas Tuttle" <[email protected]>

• Prev by Date: PATCH: Integrate asus_acpi LED's with new LED subsystem
• Next by Date: [PATCH] Fix poll() nfds check.
• Previous by thread: Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
• Next by thread: Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]