Re: [patch] reduce IPI noise due to /dev/cdrom open/close

Andrew Morton writes:

> But I think it'd be better to do just a single raw_smp_processor_id() for
> this entire function:
> 
>   static void bh_lru_install(struct buffer_head *bh)
>   {
> 	struct buffer_head *evictee = NULL;
> 	struct bh_lru *lru;
> +	int cpu;
> 
> 	check_irqs_on();
> 	bh_lru_lock();
> +	cpu = raw_smp_processor_id();
> -	lru = &__get_cpu_var(bh_lrus);
> +	lru = per_cpu(bh_lrus, cpu);

Better still, use the __raw_get_cpu_var() that I introduced.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch] reduce IPI noise due to /dev/cdrom open/close
    • From: Jes Sorensen <[email protected]>
  • Re: [patch] reduce IPI noise due to /dev/cdrom open/close
    • From: Keith Owens <[email protected]>
  • Re: [patch] reduce IPI noise due to /dev/cdrom open/close
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Generic interface for accelerometers (AMS, HDAPS, ...)
• Next by Date: Re: [PATCH] sched: Add SCHED_BGND (background) scheduling policy
• Previous by thread: Re: [patch] reduce IPI noise due to /dev/cdrom open/close
• Next by thread: Re: [patch] reduce IPI noise due to /dev/cdrom open/close
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]