While all the if_changed family filter $(PHONY) from the list of newer
files, if_changed_dep was only filtering FORCE from the list of all
dependents. This resulted in forced recompile every time.
Signed-off-by: Milton Miller <[email protected]>
---
Sam,
I have been working on some cleanups in arch/powerpc/boot/Makefile,
switching to if_changed and friends. There are rules to copy headers
from the kernel environment to the boot environment, applying slight
cleanups.
Currently a subset of the c files depend on the headers, and there is
a manual dependency on the headers. I was trying to get if_changed_dep
to depend only on the headers actually used, but copy all needed headers
before compiling any C files in the zImage code.
Does the following patch look ok to you? It removes all PHONY targets
from the list of all dependents, not just FORCE. I'm thinking the clause
is to catch files haven't been generated and therefore are not newer but
are still required. If you want to build every time you can just call cmd.
milton
Two excerpts from the proposed makefile follow:
> -$(addprefix $(obj)/,$(zlib) main.o): $(addprefix $(obj)/,$(zliblinuxheader)) $(addprefix $(obj)/,$(zlibheader))
> -#$(addprefix $(obj)/,main.o): $(addprefix $(obj)/,zlib.h)
> +linuxheader := zlib.h zconf.h zutil.h
>
> [ $(obj-boot): %.o: %.c ]
>
> +$(obj-boot): COPYHEADERS
> +COPYHEADERS: $(addprefix $(obj)/,$(linuxheader) $(zlibheader))
> +PHONY += COPYHEADERS
Index: kernel/scripts/Kbuild.include
===================================================================
--- kernel.orig/scripts/Kbuild.include 2006-07-01 00:58:38.926249877 -0500
+++ kernel/scripts/Kbuild.include 2006-07-01 01:02:00.909937514 -0500
@@ -131,7 +131,7 @@ if_changed = $(if $(strip $(filter-out $
# execute the command and also postprocess generated .d dependencies
# file
if_changed_dep = $(if $(strip $(filter-out $(PHONY),$?) \
- $(filter-out FORCE $(wildcard $^),$^) \
+ $(filter-out $(PHONY) $(wildcard $^),$^) \
$(call arg-check, $(cmd_$(1)), $(cmd_$@)) ), \
@set -e; \
$(echo-cmd) $(cmd_$(1)); \
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
