Linus Torvalds wrote:
Anyway, "urb->transfer_buffer" was initialized with urb->transfer_buffer = skb->data; and I'm pretty damn sure you're supposed to just kfree() it.
eh? I would think dev_kfree_skb(), because who knows whether the skb was cloned, split, data buffer adjusted, destructors need to be called...
kfree()ing skb->data sounds like a recipe for corruption and crashes... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [git pull] Input update for 2.6.17
- From: Linus Torvalds <torvalds@osdl.org>
- Re: [git pull] Input update for 2.6.17
- References:
- [git pull] Input update for 2.6.17
- From: Dmitry Torokhov <dtor_core@ameritech.net>
- Re: [git pull] Input update for 2.6.17
- From: Linus Torvalds <torvalds@osdl.org>
- Re: [git pull] Input update for 2.6.17
- From: Greg KH <greg@kroah.com>
- Re: [git pull] Input update for 2.6.17
- From: Linus Torvalds <torvalds@osdl.org>
- Re: [git pull] Input update for 2.6.17
- From: Linus Torvalds <torvalds@osdl.org>
- Re: [git pull] Input update for 2.6.17
- From: Linus Torvalds <torvalds@osdl.org>
- Re: [git pull] Input update for 2.6.17
- From: Marcel Holtmann <marcel@holtmann.org>
- Re: [git pull] Input update for 2.6.17
- From: Linus Torvalds <torvalds@osdl.org>
- Re: [git pull] Input update for 2.6.17
- From: Linus Torvalds <torvalds@osdl.org>
- [git pull] Input update for 2.6.17
- Prev by Date: Re: Network namespaces a path to mergable code.
- Next by Date: Re: 2.6.17-mm3: arm: *_irq_wake compile error
- Previous by thread: Re: [git pull] Input update for 2.6.17
- Next by thread: Re: [git pull] Input update for 2.6.17
- Index(es):
![]() |