Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)

On Sat, 24 Jun 2006, Arjan van de Ven wrote:

> > >
> > > in general, a function call is 100% predictable without any real control
> > > flow dependencies for the processor, and thus there is no real issue in
> > > the execution pipeline. An if is a conditional branch, which breaks up
> > > the execution pipeline if mispredicted...
> >
> > But doesn't the unlikely help the prediction?
>
> nope none at all, at least not on x86/x86-64.
> (in fact there is no way to help the prediction on those architectures
> that actually works)
>

But doesn't gcc optimize it. That is, it puts the code in the if block
as the jump. So if you never take the if, the pipeline is not hurt.

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
    • From: Steven Rostedt <[email protected]>
  • Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
    • From: Steven Rostedt <[email protected]>
  • Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: RE: [PATCH] riport LADAR driver
• Next by Date: Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
• Previous by thread: Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
• Next by thread: Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]