Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)

> 
> Because at that callsite, NULL is the common case.  We avoid a do-nothing
> function call most of the time.  It's a nano-optimisation.

but a function call is basically free, while an if () is not... even
with unlikely()...

sounds like a misoptimization to me.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
  - From: "Pekka Enberg" <[email protected]>
- Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
  - From: Steven Rostedt <[email protected]>

References:
- Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
  - From: Jeff Garzik <[email protected]>
- Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
  - From: Andrew Morton <[email protected]>

Prev by Date: Re: [RFC] [PATCH 2/2] kdump: cciss driver initialization issue fix
Next by Date: Re: [PATCH] kprobes for s390 architecture
Previous by thread: Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
Next by thread: Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]