Linux Kernel Mailing List wrote:
diff --git a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c index 8a29ce3..27d6587 100644 --- a/drivers/scsi/sata_vsc.c +++ b/drivers/scsi/sata_vsc.c @@ -433,13 +433,14 @@ err_out:/*- * 0x1725/0x7174 is the Vitesse VSC-7174 - * 0x8086/0x3200 is the Intel 31244, which is supposed to be identical - * compatibility is untested as of yet + * Intel 31244 is supposed to be identical. + * Compatibility is untested as of yet. */ static const struct pci_device_id vsc_sata_pci_tbl[] = { - { 0x1725, 0x7174, PCI_ANY_ID, PCI_ANY_ID, 0x10600, 0xFFFFFF, 0 }, - { 0x8086, 0x3200, PCI_ANY_ID, PCI_ANY_ID, 0x10600, 0xFFFFFF, 0 }, + { PCI_VENDOR_ID_VITESSE, PCI_DEVICE_ID_VITESSE_VSC7174, + PCI_ANY_ID, PCI_ANY_ID, 0x10600, 0xFFFFFF, 0 }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_GD31244, + PCI_ANY_ID, PCI_ANY_ID, 0x10600, 0xFFFFFF, 0 }, { } };
WTF? This is a REGRESSION from the repeatedly expressed desire -- clear throughout libata -- that single-use PCI device IDs should not ever receive PCI_DEVICE_ID_xxx constants.
I'm going to queue up a revert patch for this silliness.Next time, please let the relevant maintainer(s) know when you are touching their driver, so they have a chance to filter out the crap.
This was -never- sent to me or linux-ide, or otherwise brought to the attention of the maintainers.
Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] PCI: Move various PCI IDs to header file
- From: "Randy.Dunlap" <[email protected]>
- Re: [PATCH] PCI: Move various PCI IDs to header file
- Prev by Date: Re: make PROT_WRITE imply PROT_READ
- Next by Date: Re: how I know if a interrupt is ioapic_edge_type or ioapic_level_type? [Was Re: [Fwd: Re: [Linux-usb-users] Fwd: Re: 2.6.17-rc6-mm2 - USB issues]]
- Previous by thread: Re: how to access pci memory from driver?
- Next by thread: Re: [PATCH] PCI: Move various PCI IDs to header file
- Index(es):
 |